-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1992/#review4639
-----------------------------------------------------------



src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc
<http://reviews.gem5.org/r/1992/#comment4410>

    if you want to make things shorter you can always use auto for these...



src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc
<http://reviews.gem5.org/r/1992/#comment4411>

    spacing



src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc
<http://reviews.gem5.org/r/1992/#comment4412>

    ref instead of a copy?


- Andreas Hansson


On Aug. 27, 2013, 1:33 p.m., Nilay Vaish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1992/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 1:33 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 9849:da44078ebc60
> ---------------------------
> ruby: network: shorten variable names
> 
> 
> Diffs
> -----
> 
>   src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 3f6e2f267aba 
>   src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 3f6e2f267aba 
>   src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 3f6e2f267aba 
>   src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 3f6e2f267aba 
>   src/mem/ruby/network/simple/SimpleNetwork.hh 3f6e2f267aba 
>   src/mem/ruby/network/simple/SimpleNetwork.cc 3f6e2f267aba 
>   src/mem/ruby/network/simple/Switch.hh 3f6e2f267aba 
>   src/mem/ruby/network/simple/Switch.cc 3f6e2f267aba 
> 
> Diff: http://reviews.gem5.org/r/1992/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilay Vaish
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to