----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1994/#review4670 -----------------------------------------------------------
src/base/statistics.hh <http://reviews.gem5.org/r/1994/#comment4424> This should be default anyways, why is this needed? src/mem/ruby/network/garnet/BaseGarnetNetwork.hh <http://reviews.gem5.org/r/1994/#comment4425> Could you add a doxy line describing what they are supposed to do? Is any subclass actually doing anything with clearStats? src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.hh <http://reviews.gem5.org/r/1994/#comment4426> const double return seems a bit excessive :-) src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh <http://reviews.gem5.org/r/1994/#comment4427> const unsigned int returned for a good reason? Seems like a great step in the right direction. Thanks Nilay! - Andreas Hansson On Aug. 27, 2013, 1:36 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1994/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2013, 1:36 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9852:5210d8b0f5ce > --------------------------- > ruby: network: convert to gem5 style stats > > > Diffs > ----- > > src/base/statistics.hh 3f6e2f267aba > src/mem/ruby/network/Network.hh 3f6e2f267aba > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 3f6e2f267aba > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc 3f6e2f267aba > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.hh 3f6e2f267aba > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 3f6e2f267aba > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 3f6e2f267aba > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh 3f6e2f267aba > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc 3f6e2f267aba > src/mem/ruby/network/orion/NetworkPower.cc 3f6e2f267aba > src/mem/ruby/network/simple/PerfectSwitch.hh 3f6e2f267aba > src/mem/ruby/network/simple/PerfectSwitch.cc 3f6e2f267aba > src/mem/ruby/network/simple/SimpleNetwork.hh 3f6e2f267aba > src/mem/ruby/network/simple/SimpleNetwork.cc 3f6e2f267aba > src/mem/ruby/network/simple/Switch.hh 3f6e2f267aba > src/mem/ruby/network/simple/Switch.cc 3f6e2f267aba > src/mem/ruby/network/simple/Throttle.hh 3f6e2f267aba > src/mem/ruby/network/simple/Throttle.cc 3f6e2f267aba > src/mem/ruby/system/System.cc 3f6e2f267aba > > Diff: http://reviews.gem5.org/r/1994/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
