----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2002/#review4702 -----------------------------------------------------------
Ship it! seems fine to me.. only feedback in tolerace seems like it should be configurable and an int rather than a bool - Ali Saidi On Sept. 6, 2013, 5:38 p.m., Mitch Hayenga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2002/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 5:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Adds tolerance to the existing stride prefetcher. > > Forces the prefetcher to mispredict twice in a row before resetting the > confidence of prefetching. This helps cases where a load PC strides by a > constant factor, however it may operate on different arrays at times. Avoids > the cost of retraining. Primarily helps with small iteration loops. > > Note: Relies on the patch from review request #2000 > > Improves performance by 2.1% on SPECINT, 0.3% on SPECFP (geomean). > > > Diffs > ----- > > src/mem/cache/prefetch/stride.cc a317086a3e19 > src/mem/cache/prefetch/stride.hh a317086a3e19037a2b0c8332b7cb8c411aab390d > > Diff: http://reviews.gem5.org/r/2002/diff/ > > > Testing > ------- > > > Thanks, > > Mitch Hayenga > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
