Hi Andreas,
I guess you missed my email from a few days ago where I pointed out the same problem with the switcheroo simout files... I made the mistake of just replying to the changeset where I updated stats rather than giving it a new subject line, so perhaps you overlooked it. Looking at the output, I think we should probably not bother to check the stats.txt files either. Right now, the way the tester is written, it always tries to update simout, simerr, stats.txt, and config.ini (see needed_files in tests/SConscript). So to get rid of those files permanently we'd need to change that code. It really only matters when you specify update_ref; basically update_ref updates those four files plus any other outputs that are already present in the reference file list for that benchmark, and warns if any of those files aren't present. I suppose we could stick with the warning, but not update simout or stats.txt if they don't already exist in the reference file set. There will also be a problem in running the test itself; the tester may well crash if there's no reference simout or stats.txt to compare with. Or perhaps we need a way of marking a test as 'completion only' and saying don't bother to store or compare with any reference output, just verify that it didn't crash. One quick and dirty hack would be to look for 'switcheroo' in the test name, but it would be nice to do something a little more elegant. Steve On Wed, Oct 2, 2013 at 2:23 AM, Andreas Sandberg <[email protected]>wrote: > Hi Everyone, > > As I updated the stats after the x87 changes, I noticed that some of the > regressions have huge simout files. In fact, the switcheroo test has a > simout reference that is larger than the maximum allowed commit size. There > are at least two reasons why this is causing trouble. First, it's not > possible to update the file in a normal commit due to the size limit. > Second, it makes the repo larger than necessary. > > My intention when designing the benchmark was that it would only check for > functional correctness. That is, that test succeeds if it runs to > completion. I'd therefore like to remove the simout files from all of the > switcheroo tests. Additionally, I wouldn't mind removing the stats file as > well. > > Any thoughts about this? > > //Andreas > ______________________________**_________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/**listinfo/gem5-dev<http://m5sim.org/mailman/listinfo/gem5-dev> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
