----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2068/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 9874:203ae148bd73 --------------------------- dev: Fix race conditions in IDE device on newer kernels Newer linux kernels and distros exercise more functionality in the IDE device than previously, exposing 2 races. The first race is the handling of aborted DMA commands would immediately report the device is ready back to the kernel and cause already in flight commands to assert the simulator when they returned and discovered an inconsitent device state. The second race was due to the Status register not being handled correctly, the interrupt status bit would get stuck at 1 and the driver eventually views this as a bad state and logs the condition to the terminal. This patch fixes these two conditions by making the device handle aborted commands gracefully and properly handles clearing the interrupt status bit in the Status register. Diffs ----- src/dev/ide_ctrl.cc 13ffc0066b76 src/dev/ide_disk.hh 13ffc0066b76 src/dev/ide_disk.cc 13ffc0066b76 src/sim/serialize.hh 13ffc0066b76 util/cpt_upgrader.py 13ffc0066b76 Diff: http://reviews.gem5.org/r/2068/diff/ Testing ------- Thanks, Ali Saidi _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
