----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2064/#review4783 -----------------------------------------------------------
Looks good other than some indentation issues. I quickly checked the style guide and it doesn't mention how parameter lists should be indented, but it seems like the most common way to do it is to align the first parameter on each row. src/sim/sim_events.hh <http://reviews.gem5.org/r/2064/#comment4508> Indentation src/sim/sim_events.cc <http://reviews.gem5.org/r/2064/#comment4505> Indentation src/sim/sim_events.cc <http://reviews.gem5.org/r/2064/#comment4506> Shouldn't this just be SERIALIZE_SCALAR(cause)? src/sim/sim_events.cc <http://reviews.gem5.org/r/2064/#comment4507> UNSERIALIZE_SCALAR(cause)? src/sim/sim_events.cc <http://reviews.gem5.org/r/2064/#comment4504> Indentation - Andreas Sandberg On Oct. 17, 2013, 6:57 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2064/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 6:57 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9870:e36d1a8d6ffc > --------------------------- > sim: added option to serialize SimLoopExitEvent > > SimLoopExitEvents weren't serialized by default. Some benchmarks > utilize a delayed m5 exit pseudo op call to terminate the simulation > and this event was lost when resuming from a checkpoint generated > after the pseudo op call. This patch adds the capability to serialize > the SimLoopExitEvents and enable serialization for m5_exit and m5_fail > pseudo ops by default. Does not affect other generic > SimLoopExitEvents. > > > Diffs > ----- > > src/sim/pseudo_inst.cc 13ffc0066b76 > src/sim/sim_events.hh 13ffc0066b76 > src/sim/sim_events.cc 13ffc0066b76 > src/sim/sim_exit.hh 13ffc0066b76 > > Diff: http://reviews.gem5.org/r/2064/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
