> On Oct. 18, 2013, 9:45 a.m., Andreas Sandberg wrote: > > Is this a flag that we expect to be used by other ISAs or the rest of the > > memory system (e.g., caches) is it going to stay ARM-specific? In the > > latter case, it should probably be stored in the ARCH_BITS part of the > > flags field instead. > > > > Looks OK other than the question above.
I would expect it to be used for other ISAs. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2062/#review4786 ----------------------------------------------------------- On Oct. 17, 2013, 4:57 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2062/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 4:57 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9868:e8f9529476a1 > --------------------------- > mem: Add privilege info to request class > > This patch adds a flag in the request class that indicates if the request > was made in privileged mode. > > > Diffs > ----- > > src/arch/arm/tlb.cc 13ffc0066b76 > src/mem/request.hh 13ffc0066b76 > > Diff: http://reviews.gem5.org/r/2062/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
