----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2159/#review4896 -----------------------------------------------------------
You comment that "we are currently limited to configurations where there is only one KVM CPU per event queue"... can you expand on this? I.e., why can't I have multiple KVM CPUs per event queue and timeslice among them? Or is that not what you meant? src/cpu/kvm/base.hh <http://reviews.gem5.org/r/2159/#comment4563> seems to be a typo in this comment... should this be "is called as"? src/cpu/kvm/base.cc <http://reviews.gem5.org/r/2159/#comment4564> I wasn't sure why you changed from sigprocmask to pthread_sigmask, but on googling for the answer I found this: http://stackoverflow.com/questions/2170672/sigprocmask-causing-segfault So it makes sense to me now, but might be worth a mention in the commit message. - Steve Reinhardt On Feb. 9, 2014, 12:01 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2159/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2014, 12:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10062:ec5050f0c501 > --------------------------- > kvm: Add support for multi-system simulation > > The introduction of parallel event queues added most of the support > needed to run multiple VMs (systems) within the same gem5 > instance. This changeset fixes up signal delivery so that KVM's > control signals are delivered to the thread that executes the CPU's > event queue. > > Since CPUs must execute in their own threads, we are currently limited > to configurations where there is only one KVM CPU per event queue. In > practice, this means that multi-system configurations can be > simulated, but not multiple CPUs in a shared-memory configuration. > > > Diffs > ----- > > src/cpu/kvm/base.hh 3b0d0c988ed6 > src/cpu/kvm/base.cc 3b0d0c988ed6 > src/cpu/kvm/timer.cc 3b0d0c988ed6 > > Diff: http://reviews.gem5.org/r/2159/diff/ > > > Testing > ------- > > Tested boot and interactive use of single CPU system -- works. > Tested boot of dual-system configuration and interactive use -- works. > > Did not run regressions as the current tests do not test KVM functionality. > > Also available from the multisys branch in git://github.com/andysan/gem5.git. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
