> On Feb. 25, 2014, 6:45 p.m., Nathan Binkert wrote: > > util/protolib.py, line 38 > > <http://reviews.gem5.org/r/2165/diff/1/?file=39277#file39277line38> > > > > Where possible, it's nice to keep the copyrights separate. If you've > > directly lifted google code, can you put that code in a separate file? If > > not, no big deal, it's just nice to be able to drop a license when the > > original code is no longer used.
Good point. I'd say let's keep protolib.py as it is (both Google and ARM copyright). The Google copyright can be removed from the encode and decode scripts though. I'll repost the patch. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2165/#review4924 ----------------------------------------------------------- On Feb. 21, 2014, 1:30 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2165/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 1:30 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10079:1b871a9a8277 > --------------------------- > mem: Edit proto Packet and enhance the python script > > This patch changes the decode script to output the optional fields of > the proto message Packet, namely id and flags. The flags field is set > by the communication monitor. > > The id field is useful for CPU trace experiments, e.g. linking the > fetch side to decode side. It had to be renamed because it clashes > with a built in python function id() for getting the "identity" of an > object. > > This patch also takes a few common function definitions out from the > multiple scripts and adds them to a protolib python module. > > > Diffs > ----- > > src/proto/packet.proto 2360411a16be > util/decode_packet_trace.py 2360411a16be > util/encode_packet_trace.py 2360411a16be > util/protolib.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2165/diff/ > > > Testing > ------- > > All regressions pass. Note that we have _not_ updated the version > number (given that this field was optional, and most likely not > widely used). > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
