----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2176/#review4942 -----------------------------------------------------------
If there are no objections I'll go ahead and push this in the next few days. - Andreas Hansson On Feb. 26, 2014, 10:53 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2176/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 10:53 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10099:29f058c6b703 > --------------------------- > arm: Handle functional TLB walks properly > > The table walker code currently accounts for two types of walks, > Atomic and Timing, and treats them differently. Atomic walks keep a > single instance of WalkerState around for all walks to use in > currState. Timing mode keeps a queue of in-flight WalkerStates and > maintains currState as NULL between walks. > > If a functional walk is done during Timing mode, it is treated as an > atomic walk and either creates a persistent WalkerState if in between > Timing walks, or stomps an existing currState for an in-progress > Timing walk. > > This patch distinguishes functional walks as being able to exist at > any time and sets up a temporary WalkerState for its exclusive use and > then cleans up when finished, leaving any in progress Atomic or Timing > walks undisturbed. > > > Diffs > ----- > > src/arch/arm/table_walker.cc d76312a74915 > > Diff: http://reviews.gem5.org/r/2176/diff/ > > > Testing > ------- > > All regressions pass > > Runs with the checker that previously caused problems now work fine > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
