> On April 10, 2014, 4:58 p.m., Nilay Vaish wrote: > > configs/ruby/Ruby.py, line 102 > > <http://reviews.gem5.org/r/2224/diff/2/?file=39527#file39527line102> > > > > I am not in favour of adding such ad hoc checks to the config file.
I am not quite sure what you mean. There are other instances in the config scripts where string comparisons are done, so there is a long precedent for that (including a patch that was recently committed). Do you prefer doing something like if type(topology) == Cluster? If so, I tried that initially, but it required adding additional imports to the top of Ruby.py, and created some other complications that prevents it from running. - Malek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2224/#review5007 ----------------------------------------------------------- On April 10, 2014, 4:17 p.m., Malek Musleh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2224/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 4:17 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10158:97c7a8d9ea1e > --------------------------- > ruby: cluster topology config fix > > This patch adds a missing member function, and updates the ruby config file > to include the list of controllers for the Cluster topology. Previously the > list of controllers was not being passed to the topology. > > > Diffs > ----- > > configs/ruby/Ruby.py 5c2ecad1a3c9 > configs/topologies/Cluster.py 5c2ecad1a3c9 > src/mem/ruby/slicc_interface/AbstractController.hh 5c2ecad1a3c9 > > Diff: http://reviews.gem5.org/r/2224/diff/ > > > Testing > ------- > > > Thanks, > > Malek Musleh > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
