----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2239/#review5037 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On April 23, 2014, 12:19 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2239/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 12:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10191:12e1b3452d01 > --------------------------- > mem: Auto-generate CommMonitor trace file names > > Splits the CommMonitor trace_file parameter into three parameters. Previously, > the trace was only enabled if the trace_file parameter was set, and would be > written to this file. This patch adds in a trace_enable and trace_compress > parameter to the CommMonitor. > > No trace is generated if trace_enable is set to False. If it is set to True, > the > trace is written to a file based on the name of the SimObject in the > simulation > hierarchy. For example, system.cluster.il1_commmonitor.trc. This filename can > be > overridden by additionally specifying a file name to the trace_file parameter > (more on this later). > > The trace_compress parameter will append .gz to any filename if set to True. > This enables compression of the generated traces. If the file name already > ends > in .gz, then no changes are made. > > The trace_file parameter will override the name set by the trace_enable > parameter. In the case that the specified name does not end in .gz but > trace_compress is set to true, .gz is appended to the supplied file name. > > > Diffs > ----- > > src/mem/CommMonitor.py e40b35147270 > src/mem/comm_monitor.cc e40b35147270 > tests/configs/tgen-simple-mem.py e40b35147270 > > Diff: http://reviews.gem5.org/r/2239/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev