----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2251/#review5041 -----------------------------------------------------------
Ship it! I am fine with the patch as such. Can you explain what is arbitrary about the tick recorded in the InstRecord as of now? - Nilay Vaish On April 23, 2014, 12:24 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2251/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 12:24 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10203:8ae7d6abbefb > --------------------------- > cpu: Allow setWhen on trace objects > > Allow setting of 'when' in trace records. This allows later times > than the arbitrary record creation point to be used as inst. times > > > Diffs > ----- > > src/sim/insttracer.hh e40b35147270 > > Diff: http://reviews.gem5.org/r/2251/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
