> On May 5, 2014, 6:06 a.m., Steve Reinhardt wrote: > > src/arch/isa_parser.py, line 2233 > > <http://reviews.gem5.org/r/2247/diff/1/?file=39628#file39628line2233> > > > > I can see that this is more localized, but what about just going into > > the templates and replacing '%(CPU_exec_context)s' with CPU_EXEC_CONTEXT > > (perl -pi -e could do this in a flash)... then we wouldn't need this > > function at all. > > > > Particularly if you're worried about runtime, it seems odd to to this > > same static substitution dynamically every time we run the parser vs. just > > doing it once for all time offline.
I agree with this and will update the patch. - Curtis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2247/#review5083 ----------------------------------------------------------- On April 23, 2014, 12:23 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2247/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 12:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10199:5f265b5de1c5 > --------------------------- > arch: teach ISA parser how to split code across files > > This patch is the first step in enabling the ISA-parser to split the > output into multiple files and thereby reach a more sensible > compilation-unit size. > > > Diffs > ----- > > src/arch/isa_parser.py e40b35147270 > > Diff: http://reviews.gem5.org/r/2247/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
