----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2281/#review5122 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On June 1, 2014, 12:47 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2281/ > ----------------------------------------------------------- > > (Updated June 1, 2014, 12:47 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10231:df1b95c06e38 > --------------------------- > style: eliminate equality tests with true and false > > Using '== true' in a boolean expression is totally redundant, > and using '== false' is pretty verbose (and arguably less > readable in most cases) compared to '!'. > > It's somewhat of a pet peeve, perhaps, but I had some time > waiting for some tests to run and decided to clean these up. > > Unfortunately, SLICC appears not to have the '!' operator, > so I had to leave the '== false' tests in the SLICC code. > > > Diffs > ----- > > src/arch/mips/tlb.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/arch/power/tlb.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/arch/sparc/tlb.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/arch/x86/pagetable_walker.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/base/loader/hex_file.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/base/match.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/exetrace.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/inorder/cpu.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/inorder/pipeline_stage.cc a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/inorder/resources/use_def.cc > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/o3/commit_impl.hh a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/o3/fetch_impl.hh a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/o3/iew_impl.hh a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/o3/inst_queue_impl.hh a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/o3/lsq_unit_impl.hh a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/o3/rob_impl.hh a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/cpu/ozone/inst_queue_impl.hh a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/mem/protocol/MOESI_CMP_token-L1cache.sm > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/mem/protocol/MOESI_CMP_token-L2cache.sm > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/mem/protocol/MOESI_CMP_token-dir.sm > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/mem/ruby/buffers/MessageBuffer.cc > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/mem/ruby/slicc_interface/NetworkMessage.hh > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/mem/ruby/system/DMASequencer.cc > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > src/mem/slicc/ast/PeekStatementAST.py > a2bb75a474fd9b5f99c15fd75e79b4fa9e8e8f54 > > Diff: http://reviews.gem5.org/r/2281/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
