----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2299/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10254:a094bfd1088e --------------------------- cpu: Fix SMT scheduling issue with the O3 cpu The o3 cpu could attempt to schedule inactive threads under round-robin SMT mode. This is because it maintained an independent priority list of threads from the active thread list. This priority list could be come stale once threads were inactive, leading to the cpu trying to fetch/commit from inactive threads. Additionally the fetch queue is now forcibly flushed of instrctuctions from the de-scheduled thread. Relevant output: 24557000: system.cpu: [tid:1]: Calling deactivate thread. 24557000: system.cpu: [tid:1]: Removing from active threads list 24557500: system.cpu: FullO3CPU: Ticking main, FullO3CPU. 24557500: system.cpu.fetch: Running stage. 24557500: system.cpu.fetch: Attempting to fetch from [tid:1] Diffs ----- src/cpu/o3/commit.hh a2bb75a474fd src/cpu/o3/commit_impl.hh a2bb75a474fd src/cpu/o3/cpu.cc a2bb75a474fd src/cpu/o3/fetch.hh a2bb75a474fd src/cpu/o3/fetch_impl.hh a2bb75a474fd Diff: http://reviews.gem5.org/r/2299/diff/ Testing ------- Thanks, Ali Saidi _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
