----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2298/#review5146 -----------------------------------------------------------
src/cpu/pred/2bit_local.hh <http://reviews.gem5.org/r/2298/#comment4670> should have a blank line here IMO. Also this comment is redundnant wrt comment on original (overridden) declaration on BPredUnit. Do we have a policy on this? Nice to have comments in both places, but the redundancy could lead to divergence if one is updated and the other not. Already have redundant typos... src/cpu/pred/2bit_local.hh <http://reviews.gem5.org/r/2298/#comment4671> and only one blank line here src/cpu/pred/bpred_unit.hh <http://reviews.gem5.org/r/2298/#comment4672> blank line here. also typo 'iwth' src/cpu/pred/bpred_unit.hh <http://reviews.gem5.org/r/2298/#comment4673> typo 'Whether' src/cpu/pred/tournament.hh <http://reviews.gem5.org/r/2298/#comment4674> don't delete blank line here src/cpu/pred/tournament.hh <http://reviews.gem5.org/r/2298/#comment4676> YA redundant comment w/typo src/cpu/pred/tournament.hh <http://reviews.gem5.org/r/2298/#comment4675> add blank line here - Steve Reinhardt On June 12, 2014, 3:50 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2298/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 3:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10253:992be57d8ca3 > --------------------------- > cpu: Fix incorrect speculative branch predictor behavior > > When a branch mispredicted gem5 would squash all history after and including > the mispredicted branch. However, the mispredicted branch is still > speculative > and its history is required to rollback state if another, older, branch > mispredicts. This leads to things like RAS corruption. > > > Diffs > ----- > > src/cpu/pred/2bit_local.hh a2bb75a474fd > src/cpu/pred/bpred_unit.hh a2bb75a474fd > src/cpu/pred/bpred_unit_impl.hh a2bb75a474fd > src/cpu/pred/tournament.hh a2bb75a474fd > src/cpu/pred/tournament.cc a2bb75a474fd > > Diff: http://reviews.gem5.org/r/2298/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
