----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2304/#review5174 -----------------------------------------------------------
Ship it! src/base/inet.hh <http://reviews.gem5.org/r/2304/#comment4689> seems like it would be more consistent with the other code to do a loop up to ETH_ADDR_LEN, but this works too. - Steve Reinhardt On June 26, 2014, 2:49 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2304/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 2:49 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10243:f30073e2cb22 > --------------------------- > base: fix some bugs in EthAddr > > per the IEEE 802 spec: > 1) fixed broadcast() to ensure that all bytes are equal to 0xff. > 2) fixed unicast() to ensure that bit 0 of the first byte is equal to 0 > 3) fixed multicast() to ensure that bit 0 of the first byte is equal to 1, and > that it is not a broadcast. > > also the constructors in EthAddr are fixed so that all bytes of data are > initialized. > > > Diffs > ----- > > src/base/inet.hh cb4e86c177672fde6be7a409793c944e36353fc0 > src/base/inet.cc cb4e86c177672fde6be7a409793c944e36353fc0 > > Diff: http://reviews.gem5.org/r/2304/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
