----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2302/#review5181 -----------------------------------------------------------
Ship it! As I mentioned before, I'm not opposed this going in as is if adding the check in Ruby is more than a line or two of code. - Andreas Hansson On June 21, 2014, 4:53 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2302/ > ----------------------------------------------------------- > > (Updated June 21, 2014, 4:53 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10239:ef2bd7e9922c > --------------------------- > x86: make PioBus return BadAddress errors > > Stop setting the use_default_range flag in PioBus in order to > have random bad addresses result in a BadAddress response and > not a gem5 fatal error. This is necessary in Ruby as Ruby is > connected directly to PioBus, so misspeculated addresses will > be sent there directly. For the classic memory system, this > change has no effect, as bad addresses are caught by the > memory bus before being sent to the PioBus. > > This work was done while Binh was an intern at AMD Research. > > > Diffs > ----- > > src/dev/x86/Pc.py b21b3aad6bd1d01ac8a4d8030479bbca417af8d1 > > Diff: http://reviews.gem5.org/r/2302/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
