> On July 14, 2014, 7:36 p.m., Andreas Sandberg wrote: > > In general, I like the idea of having a proper, architected, page table in > > SE-mode. Long-term, this could hopefully mean that we can get rid of many > > of the differences between SE- and FS-mode. > > > > High-level comments: > > > > * Write a proper commit message (see http://www.m5sim.org/Commit_Access). > > Specifically, include a short one-line summary and a longer description of > > what the patch does and why. There is currently now way of telling what > > this patch intends to accomplish. > > > > * Don't set the execute bit on src/sim/SConscript. > > > > * Split into an architecture-agnostic patch and an x86-specific patch. > >
Also, please document what the architecture-specific page tables are supposed to do. A good place could be the PageTableBase class. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2312/#review5188 ----------------------------------------------------------- On July 11, 2014, 5:57 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2312/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 5:57 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10253:359daed0c723 > --------------------------- > Multi-level page table class. > This is part of the larger effort of supporting virtualized execution in SE > mode. > > > Diffs > ----- > > src/arch/alpha/process.hh c625a3c51bac050879457e666dd83299a36d761b > src/arch/arm/process.hh c625a3c51bac050879457e666dd83299a36d761b > src/arch/mips/process.hh c625a3c51bac050879457e666dd83299a36d761b > src/arch/power/process.hh c625a3c51bac050879457e666dd83299a36d761b > src/arch/sparc/process.hh c625a3c51bac050879457e666dd83299a36d761b > src/arch/x86/pagetable.hh c625a3c51bac050879457e666dd83299a36d761b > src/arch/x86/pagetable_walker.cc c625a3c51bac050879457e666dd83299a36d761b > src/arch/x86/process.hh c625a3c51bac050879457e666dd83299a36d761b > src/arch/x86/system.hh c625a3c51bac050879457e666dd83299a36d761b > src/mem/SConscript c625a3c51bac050879457e666dd83299a36d761b > src/mem/multi_level_page_table.hh PRE-CREATION > src/mem/multi_level_page_table.cc PRE-CREATION > src/mem/multi_level_page_table_impl.hh PRE-CREATION > src/mem/page_table.hh c625a3c51bac050879457e666dd83299a36d761b > src/sim/Process.py c625a3c51bac050879457e666dd83299a36d761b > src/sim/SConscript c625a3c51bac050879457e666dd83299a36d761b > src/sim/process.hh c625a3c51bac050879457e666dd83299a36d761b > src/sim/process.cc c625a3c51bac050879457e666dd83299a36d761b > > Diff: http://reviews.gem5.org/r/2312/diff/ > > > Testing > ------- > > Regressions passed. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
