----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2346/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10290:a1d9e3ccce34 --------------------------- ruby: slicc: improve the grammar This patch changes the grammar for SLICC so as to remove some of the redundant / duplicate rules. In particular rules for object/variable declaration and class member declaration have been unified. Similarly, the rules for a general function and a class method have been unified. One more change is in the priority of two rules. The first rule is on declaring a function with all the params typed and named. The second rule is on declaring a function with all the params only typed. Earlier the second rule had a higher priority. Now the first rule has a higher priority. Diffs ----- src/mem/slicc/ast/FuncDeclAST.py 79fde1c67ed8 src/mem/slicc/ast/ObjDeclAST.py 79fde1c67ed8 src/mem/slicc/ast/TypeFieldMemberAST.py 79fde1c67ed8 src/mem/slicc/ast/TypeFieldMethodAST.py 79fde1c67ed8 src/mem/slicc/ast/__init__.py 79fde1c67ed8 src/mem/slicc/parser.py 79fde1c67ed8 src/mem/slicc/symbols/StateMachine.py 79fde1c67ed8 src/mem/slicc/symbols/Type.py 79fde1c67ed8 Diff: http://reviews.gem5.org/r/2346/diff/ Testing ------- Thanks, Nilay Vaish _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev