----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2327/#review5285 -----------------------------------------------------------
While I am ok with the changes made, do you think it is possible to retain the Enum instead of using 12, 14 and 16? - Nilay Vaish On Aug. 18, 2014, 9:55 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2327/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 9:55 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10288:3f7ff9a4c112 > --------------------------- > arm: support 16kb vm granules > > > Diffs > ----- > > src/arch/arm/miscregs.hh 79fde1c67ed8 > src/arch/arm/table_walker.hh 79fde1c67ed8 > src/arch/arm/table_walker.cc 79fde1c67ed8 > > Diff: http://reviews.gem5.org/r/2327/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
