----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2292/#review5301 -----------------------------------------------------------
Ship it! Looks great, thanks! - Steve Reinhardt On Aug. 22, 2014, 5:25 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2292/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 5:25 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10295:9a15d64f7738 > --------------------------- > config: Change parsing of Addr so hex values work from scripts > > When passed from a configuration script with a hexadecimal value (like > "0x80000000"), gem5 would error out. This is because it would call > "toMemorySize" which requires the argument to end with a size specifier (like > 1MB, etc). > > This modification makes it so raw hex values can be passed through Addr > parameters from the configuration scripts. > > > Diffs > ----- > > src/arch/arm/ArmSystem.py 79fde1c67ed8 > src/python/m5/params.py 79fde1c67ed8 > > Diff: http://reviews.gem5.org/r/2292/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
