----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2380/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10373:705c3217c69b --------------------------- dev: Refactor terminal<->UART interface to make it more generic The terminal currently assumes that the transport to the guest always inherits from the Uart class. This assumption breaks when implementing, for example, a VirtIO consoles. This patch removes this assumption by adding pointer to the from the terminal to the uart and replacing it with a more general callback interface. The Uart, or any other class using the terminal, class implements an instance of the callbacks class and registers it with the terminal. Diffs ----- src/dev/terminal.hh e2c43045a81b src/dev/terminal.cc e2c43045a81b src/dev/uart.hh e2c43045a81b src/dev/uart.cc e2c43045a81b Diff: http://reviews.gem5.org/r/2380/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
