----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2479/#review5452 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Nov. 15, 2014, 3 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2479/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 3 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10533:b12ba2b65334 > --------------------------- > x86: APIC: Fix the getRegArrayBit function. > > The getRegArrayBit function extracts a bit from a series of registers which > are treated as a single large bit array. A previous change had modified the > logic which figured out which bit to extract from ">> 5" to "% 5" which seems > wrong, especially when other, similar functions were changed to use "% 32". > > > Diffs > ----- > > src/arch/x86/interrupts.hh 533ec854b2f1813410287183642c13f1895215b5 > > Diff: http://reviews.gem5.org/r/2479/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
