----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2478/#review5456 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Nov. 15, 2014, 2:24 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2478/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 2:24 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10531:7334446cd610 > --------------------------- > x86: Fix the CPUID Long Mode Address Size function. > > The value in EAX has an 8 bit field for the linear address size and one for > the physical address size when calling that function. A recent change > implemented it but returned 0xff for both of those fields. That implies that > linear and physical addresses are 255 bits wide which is wrong. When using the > KVM CPU model this causes an error, presumably because some of those bits are > actually reserved, or the CPU or kernel realizes 255 bits is a bad value. > > This change makes those values 48. > > > Diffs > ----- > > src/arch/x86/cpuid.cc 533ec854b2f1813410287183642c13f1895215b5 > > Diff: http://reviews.gem5.org/r/2478/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
