Hi Nilay,

On July 24, 2013 you removed the RubySlice_Profiler.sm, 
RubySlicc_Profiler_interface.cc and RubySlicc_Profiler_interface.hh files.  See 
changeset 9771:57aac1719f86.  By removing those files, you removed the ability 
to provide protocol specific profiling.  Your comment seems to suggest that you 
expect that all profile functions called by the .sm files to use functions 
defined in AbstractController.  Is that correct?  That solution doesn't seem 
very scalable and it will lead to a very large AbstractController definition 
(I'm quite surprised how much that file has grown in the past two years...20+ 
modifications).

Do you see a better way to support protocol specific profiling?  We could add 
back in the RubySlice_Profiler.sm, RubySlicc_Profiler_interface.cc and 
RubySlicc_Profiler_interface.hh files, but I understand the benefit to have the 
functions be defined on a per machine basis.

Thanks,

Brad

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to