> On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote: > > I thought the style guide said there were supposed to be spaces around > > operators and assignments, or am I missing something? > > Gabe Black wrote: > I don't think the style guide says, or at least not that I see. I may be > tending to the style we use at work. > > Andreas Hansson wrote: > I could be wrong on this one. Steve, Ali, what are your thoughts?
Just to make sure we're all on the same page, I removed the spaces here because these are default values for arguments. My brain might have just pattern matched and applied a rule for named function arguments in python we use at work, but, unless there's a policy against it, I still like the way it looks in this case. For other uses of "=" and other operators I think there should definitely be spaces. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2523/#review5552 ----------------------------------------------------------- On Nov. 23, 2014, 7:25 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2523/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 7:25 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10560:b66945a370f9 > --------------------------- > config: Get rid of some extra spaces around default arguments. > > > Diffs > ----- > > configs/common/FSConfig.py 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2523/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev