I think it’s fine that a device wants to do this, I’d just like it to use an thin interface on the System object as a matter of clean interfaces in the object hierarchy, so unrelated objects don’t have to know about each other.
Ali On Dec 3, 2014, at 11:54 AM, Gabe Black via gem5-dev <gem5-dev@gem5.org> wrote: > > >> On Dec. 3, 2014, 11:42 a.m., Andreas Hansson wrote: >>> As this is quite invasive, how broadly would this be used? Also, is there >>> any chance of rather using devices that do not have memory of their own >>> (and rely on the "normal" system memory that is already mapped)? > > The one example I'm aware of is the cirrus graphics device on x86, and > unfortunately the existing driver assumes there's memory on the card. Our > team is reluctant to spend a significant amount of effort either writing a > new driver or specializing the image to switch to a different video device. > QEMU uses cirrus already, and since we use that for VM based testing we > already have support for it in place. > > It's all a matter of opinion of course, but this doesn't seem that invasive > to me. It's making the memory slot management a little bit more robust, and > exposing it to external consumers. KVM is already a generalized/standardized > interface to hardware virtualization, so it's not reaching behind the curtain > all that much. There is some impact, but it seems like a reasonable trade off > to me. > > > - Gabe > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2510/#review5613 > ----------------------------------------------------------- > > > On Nov. 23, 2014, 2:51 p.m., Gabe Black wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/2510/ >> ----------------------------------------------------------- >> >> (Updated Nov. 23, 2014, 2:51 p.m.) >> >> >> Review request for Default. >> >> >> Repository: gem5 >> >> >> Description >> ------- >> >> Changeset 10551:7767dc21318d >> --------------------------- >> Let other objects set up memory like regions in a KVM VM. >> >> >> Diffs >> ----- >> >> src/cpu/kvm/vm.hh f9fb64a72259a2514080151b5250a04c575d443a >> src/cpu/kvm/vm.cc f9fb64a72259a2514080151b5250a04c575d443a >> >> Diff: http://reviews.gem5.org/r/2510/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Gabe Black >> >> > > _______________________________________________ > gem5-dev mailing list > gem5-dev@gem5.org > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
