----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2549/#review5657 -----------------------------------------------------------
src/mem/ruby/system/RubyPort.cc <http://reviews.gem5.org/r/2549/#comment5048> Why are you removing these lines? Is the tester now aware when the port is blocked and does it handle retries correctly? I would prefer if it did not. We want the tester to be as aggressive as possible. - Brad Beckmann On Dec. 9, 2014, 3:15 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2549/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 3:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10602:d3bb9d95bf76 > --------------------------- > ruby: ruby port: do not check for blocked ports > RubyPort used to maintain a list of blocked ports which are sent retries when > the port becomes unblocked. This is unnecessary since RubyPort's port > definitions > inherit from QueuedPort. > > > Diffs > ----- > > src/mem/ruby/system/RubyPort.hh 6efb37480d87 > src/mem/ruby/system/RubyPort.cc 6efb37480d87 > > Diff: http://reviews.gem5.org/r/2549/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
