> On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: > > src/dev/x86/i8042.cc, line 418 > > <http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line418> > > > > We don't need this nack().
I changed the panic to a warn and left the nack in. > On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: > > src/dev/x86/i8042.cc, line 496 > > <http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line496> > > > > Is some code missing here? You did not write anything to the output > > port. The output port is really a bunch of GPIOs on the keyboard controller attached to a bunch of random things. It's not really worth implementing right now. > On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: > > src/dev/x86/i8042.cc, line 557 > > <http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line557> > > > > Do we need this change? This does not exceed the line length limit. Yes it does. If I collapse it back down, the semicolon wraps. > On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: > > src/dev/x86/i8042.cc, line 590 > > <http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line590> > > > > Do we need this change? This does not exceed the line length limit. Yes it does. If I collapse it back down, the closing parenthesis and semicolon wrap. > On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: > > src/dev/x86/i8042.cc, line 593 > > <http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line593> > > > > Do we need this change? This does not exceed the line length limit. Nope. > On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: > > src/dev/x86/i8042.cc, line 602 > > <http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line602> > > > > A single line seems possible. Nope. > On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: > > src/dev/x86/i8042.cc, line 607 > > <http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line607> > > > > A single line seems possible. Nope. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5544 ----------------------------------------------------------- On Nov. 22, 2014, 1:32 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2519/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2014, 1:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10555:595f40e72481 > --------------------------- > x86: i8042: Give the keyboard controller a little TLC. > > This CL fixes a few minor bugs, and fills out the general implementation a bit > so that it can more readily support actually returning keyboard input. > > > Diffs > ----- > > src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c > src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2519/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
