> On Dec. 12, 2014, 10:21 p.m., Gabe Black wrote: > > src/arch/arm/decoder.cc, line 61 > > <http://reviews.gem5.org/r/2565/diff/1/?file=43028#file43028line61> > > > > If I'm remembering correctly, I think I put these in the .hh so that > > they could be easily inlined by callers, although I can't quite remember > > whether I wrote this originally or just think I did. It would be worthwhile > > seeing if it affects simulator performance.
No performance change is observed. > On Dec. 12, 2014, 10:21 p.m., Gabe Black wrote: > > src/arch/arm/decoder.hh, line 221 > > <http://reviews.gem5.org/r/2565/diff/1/?file=43027#file43027line221> > > > > This isn't from your change and was probably originally done wrong by > > me, but could you please put the return type on its own line for these > > function definitions? Since you're touching everything already it seems > > like as good a time as any. In cases where the implementation appears in the header we tend to keep the return type on the same line as the definition. Why do you want to change it in this particular case? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2565/#review5683 ----------------------------------------------------------- On Dec. 12, 2014, 5:45 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2565/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 5:45 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10609:b11235acfc25 > --------------------------- > arm: Clean up and document decoder API > > This changeset adds more documentation to the ArmISA::Decoder class > and restructures it slightly to make API groups more obvious. > > > Diffs > ----- > > src/arch/arm/decoder.hh 8fc6e7a835d1 > src/arch/arm/decoder.cc 8fc6e7a835d1 > > Diff: http://reviews.gem5.org/r/2565/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
