----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2310/#review5723 -----------------------------------------------------------
My bad, wrong review :-) - Andreas Hansson On Jan. 5, 2015, 4:31 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2310/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 4:31 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10645:1e1e3186ade3 > --------------------------- > mem: Make the XBar responsible for tracking response routing > > This patch removes the need for a source and destination field in the > packet by shifting the onus of the tracking to the crossbar, much like > a real implementation. This change in behaviour also means we no > longer need a SenderState to remember the source/dest when ever we > have multiple crossbars in the system. Thus, the stack that was > created by the SenderState is not needed, and each crossbar locally > tracks the response routing. > > The fields in the packet are still left behind as the RubyPort (which > also acts as a crossbar) does routing based on them. In the succeeding > patches the uses of the src and dest field will be removed. Combined, > these patches improve the simulation performance by roughly 2%. > > > Diffs > ----- > > src/mem/coherent_xbar.hh 9ac724889705 > src/mem/coherent_xbar.cc 9ac724889705 > src/mem/noncoherent_xbar.cc 9ac724889705 > src/mem/xbar.hh 9ac724889705 > > Diff: http://reviews.gem5.org/r/2310/diff/ > > > Testing > ------- > > regressions now pass > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
