> On Feb. 3, 2015, 10:40 a.m., Stephan Diestelhorst wrote: > > Looks fine to me, too. However, when following the logic here, I found > > that this is a generally messy part of the O3 core. I think it would make > > sense to (1) restructure similar to the Minor CPU core (where there is a > > state per context) and then (2) unify this whole handling in BaseCPU and > > pull it out of the respective cores. AFAICS, this (active / idle state vs > > threading) should be generic enough to be pulled out, or at least be > > similar across the cores.
Hi Stephan, I agree with you and Andreas that (1) this whole part of the code is overly complicated and (2) it would be good to abstract as much as possible and move it to BaseCPU. However, this is just a simple bug fix, so it would be nice to get it committed and move on, and defer the restructuring to some future date. Does that sound OK? - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2607/#review5818 ----------------------------------------------------------- On Jan. 20, 2015, 4 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2607/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 4 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10652:1dd33bc912af > --------------------------- > O3CPU: Idle CPU status logic revised > This patch sets the CPU status to idle when the last active thread gets > suspended. > > > Diffs > ----- > > src/cpu/o3/cpu.cc a6fe75e8296b0dd2293596d11b2ac0f842b10463 > > Diff: http://reviews.gem5.org/r/2607/diff/ > > > Testing > ------- > > Tested ALPHA and X86 quick SE regressions. Also, tested ALPHA multi-program > SMT with small applications. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
