----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2705/#review5974 -----------------------------------------------------------
Looks great. Thanks for the contribution. A few minor things: 1) The summary should start with "dev : " (see http://gem5.org/Commit_Access for details) 2) Are any regressions affected? (or is this not impacting linux) - Andreas Hansson On March 25, 2015, 11:10 a.m., Ruslan Bukin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2705/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 11:10 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Add 32-bit access width for PrimaryTiming register and 16bit for UDMAControl > register as FreeBSD required. > > > Diffs > ----- > > src/dev/ide_ctrl.cc 8f5993cfa916 > > Diff: http://reviews.gem5.org/r/2705/diff/ > > > Testing > ------- > > Test passed OK booting FreeBSD guest. > > > Thanks, > > Ruslan Bukin > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
