----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2691/#review6028 -----------------------------------------------------------
Get the idea, but I am burnt when it comes to debugging request + packet deep copies. src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/2691/#comment5250> Since I just spent a few good hours hunting memory allocation bugs... where will these get deallocated again? It is not obvious, so maybe chuck in a comment, here? src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/2691/#comment5251> Again.. I'd like to see a comment of where these guys (or the originals) are deallocated. src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/2691/#comment5252> Why don't you break and drop the early_exit? src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/2691/#comment5253> This should really be: if (!mshr.hasTargets()) and all the stuff below has too deep an (or two) indentation level, IMHO. I seriously consider goto an appropriate way to improve readability here. - Stephan Diestelhorst On März 14, 2015, 5:19 nachm., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2691/ > ----------------------------------------------------------- > > (Updated März 14, 2015, 5:19 nachm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10745:9b84d1b570e3 > --------------------------- > mem: implement x86 locked accesses in timing-mode classic cache > > Add LockedRMW(Read|Write)(Req|Resp) commands. In timing mode, > use a combination of clearing permission bits and leaving > an MSHR in place to prevent accesses & snoops from touching > a locked block between the read and write parts of an locked > RMW sequence. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 655ff3f6352d7aa4021f8840b68698b277772806 > src/mem/packet.hh 655ff3f6352d7aa4021f8840b68698b277772806 > src/mem/packet.cc 655ff3f6352d7aa4021f8840b68698b277772806 > > Diff: http://reviews.gem5.org/r/2691/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
