----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2849/#review6482 -----------------------------------------------------------
configs/example/se.py (line 224) <http://reviews.gem5.org/r/2849/#comment5559> This seems a bit smelly. Shouldn't you at least provide a warning if this happens? I'd almost consider it a fatal error. src/cpu/o3/cpu.cc (line 218) <http://reviews.gem5.org/r/2849/#comment5560> I'd suggest making this a fatal error instead of a warning. src/cpu/o3/cpu.cc (line 357) <http://reviews.gem5.org/r/2849/#comment5561> Will this still be empty? Won't this just reuse an existing workload? - Andreas Sandberg On June 1, 2015, 3:07 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2849/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 3:07 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10858:cc93e6609fc3 > --------------------------- > config, SMT: Enabling SMT for multi-threaded programs > This patch helps enabling SMT by adding a new argument to specify the number > of hardware threads. > > > Diffs > ----- > > configs/common/Options.py d02b45a554b52c68cce41e1b3895fb8582a639dd > configs/example/se.py d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/cpu.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/inst_queue_impl.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > > Diff: http://reviews.gem5.org/r/2849/diff/ > > > Testing > ------- > > Quick regressions passed for all ISAs. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
