----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2871/#review6509 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On June 8, 2015, 11:32 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2871/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 11:32 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10869:996b20e55386 > --------------------------- > python: Remove redundant drain when changing memory modes > > When the Python helper code switches CPU models, it sometimes also > needs to change the memory mode of the simulator. When this happens, > it accidentally tried to drain the simulator despite having done so > already. This changeset removes the redundant drain. > > > Diffs > ----- > > src/python/m5/simulate.py 282c2a89ace8 > > Diff: http://reviews.gem5.org/r/2871/diff/ > > > Testing > ------- > > Long regressions (including switcheroos pass) > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev