----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2897/#review6519 -----------------------------------------------------------
Ship it! This is good clean-up. Just a minor suggestion below. src/mem/ruby/slicc_interface/Message.hh (line 94) <http://reviews.gem5.org/r/2897/#comment5598> minor: I think you can remove the comment on this line. The type of this variable outlasted MessageBufferNode itself. - Joel Hestness On June 19, 2015, 4:09 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2897/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 4:09 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10882:1af45ed3525c > --------------------------- > ruby: remove message buffer node > > This structure's only purpose was to provide a comparison function for > ordering messages in the MessageBuffer. The comparison function is now > being moved to the Message class itself. So we no longer require this > structure. > > > Diffs > ----- > > src/mem/ruby/network/MessageBuffer.hh ebb3d0737aa7 > src/mem/ruby/network/MessageBuffer.cc ebb3d0737aa7 > src/mem/ruby/network/MessageBufferNode.hh ebb3d0737aa7 > src/mem/ruby/network/MessageBufferNode.cc ebb3d0737aa7 > src/mem/ruby/network/SConscript ebb3d0737aa7 > src/mem/ruby/slicc_interface/Message.hh ebb3d0737aa7 > > Diff: http://reviews.gem5.org/r/2897/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
