-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2902/#review6523
-----------------------------------------------------------


Can you please expand on the commit message? I understand that these changes 
are to allow multiple RubySystem instances, but some detailed information about 
this should be available in the commit log.

- Joel Hestness


On June 19, 2015, 4:40 a.m., Brandon Potter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2902/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 4:40 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10877:2e6e2150542a
> ---------------------------
> ruby: removes g_system_ptr and replaces with object based references
> 
> 
> Diffs
> -----
> 
>   configs/ruby/MESI_Three_Level.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   configs/ruby/MESI_Two_Level.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   configs/ruby/MI_example.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   configs/ruby/MOESI_CMP_directory.py 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   configs/ruby/MOESI_CMP_token.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   configs/ruby/MOESI_hammer.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/protocol/RubySlicc_Types.sm 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/SConscript ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/common/Global.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/common/Global.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/network/MessageBuffer.hh 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/network/MessageBuffer.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/network/simple/SimpleNetwork.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/network/simple/Switch.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/network/simple/Throttle.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/profiler/AddressProfiler.hh 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/profiler/AddressProfiler.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/profiler/Profiler.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/profiler/Profiler.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/slicc_interface/AbstractController.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/structures/BankedArray.hh 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/structures/BankedArray.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/structures/Cache.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/structures/CacheMemory.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/structures/RubyMemoryControl.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/structures/SConscript ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/structures/WireBuffer.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/DMASequencer.hh 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/DMASequencer.cc 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/RubyPort.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/RubyPort.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/Sequencer.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/Sequencer.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/System.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/ruby/system/System.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/slicc/symbols/StateMachine.py 
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/mem/slicc/symbols/Type.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
>   src/python/swig/pyobject.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 
> 
> Diff: http://reviews.gem5.org/r/2902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to