----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2876/#review6630 -----------------------------------------------------------
Ship it! Seems fine to me. - Nilay Vaish On June 8, 2015, 5:05 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2876/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 5:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10876:01c1fa498765 > --------------------------- > sim: Fix broken event unserialization > > Events expected to be unserialized using an event-specific > unserializeEvent call. This call was never actually used, which meant > the events relying on it never got unserialized (or scheduled after > unserialization). > > Instead of relying on a custom call, we now use the normal > serialization code again. In order to schedule the event correctly, > the parrent object is expected to use the > EventQueue::checkpointReschedule() call. This happens automatically > for events that are serialized using the AutoSerialize mechanism. > > > Diffs > ----- > > src/sim/sim_events.hh 282c2a89ace8 > src/sim/sim_events.cc 282c2a89ace8 > src/dev/etherlink.cc 282c2a89ace8 > src/sim/eventq.hh 282c2a89ace8 > src/sim/eventq.cc 282c2a89ace8 > src/sim/serialize.hh 282c2a89ace8 > > Diff: http://reviews.gem5.org/r/2876/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev