> On July 2, 2015, 5:55 a.m., Nilay Vaish wrote: > > src/mem/dram_ctrl.hh, line 647 > > <http://reviews.gem5.org/r/2746/diff/1/?file=44756#file44756line647> > > > > I am guessing that somewhere you make sure that burstSize is a power of > > two.
Yes. I will add a check in the constructor. > On July 2, 2015, 5:55 a.m., Nilay Vaish wrote: > > src/mem/dram_ctrl.cc, line 436 > > <http://reviews.gem5.org/r/2746/diff/1/?file=44757#file44757line436> > > > > Just a thought. Why not add pktCount to this variable after the loop. Outside the scope of this patch, but indeed something to consider. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2746/#review6670 ----------------------------------------------------------- On April 24, 2015, 4:32 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2746/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 4:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10818:c9c3503b043a > --------------------------- > mem: Avoid DRAM write queue iteration for merging and read lookup > > This patch adds a simple lookup structure to avoid iterating over the > write queue to find read matches, and for the merging of write > bursts. Instead of relying on iteration we simply store a set of > currently-buffered write-burst addresses and compare against > these. For the reads we still perform the iteration if we have a > match. For the writes, we rely entirely on the set. Note that there > are corner-cases where sub-bursts would actually not be mergeable > without a read-modify-write. We ignore these cases and opt for speed. > > > Diffs > ----- > > src/mem/dram_ctrl.hh df2aa91dba5b > src/mem/dram_ctrl.cc df2aa91dba5b > > Diff: http://reviews.gem5.org/r/2746/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
