----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2928/#review6723 -----------------------------------------------------------
I'm not too fond of how this is done, since it essentially creates a base class that only adds baggage to the classic memory system. Is it not possible to align the two rather? Also, besides the bloat, I am also worried about performance. Have you measured the impact on the overall regression? - Andreas Hansson On June 29, 2015, 6:19 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2928/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 6:19 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10895:1e201402a79c > --------------------------- > mem: add a base packet class > > This patch adds BasePacket class from which both Packet and Message classes > are > now being derived. This class provides the API which will allows us to push > packets into the ruby memory system directly, without any conversion. In due > course, patches will be posted that do so. These patches would essentially do > away with RubyRequest and remove code from the Sequencer that allocates > SequencerRequest and RubyRequest objects for each packet received from the > processing core. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/Message.hh 73d4798871a5 > src/mem/ruby/slicc_interface/RubyRequest.hh 73d4798871a5 > src/mem/ruby/structures/WireBuffer.cc 73d4798871a5 > src/mem/slicc/symbols/Type.py 73d4798871a5 > src/mem/base_packet.hh PRE-CREATION > src/mem/packet.hh 73d4798871a5 > src/mem/packet.cc 73d4798871a5 > src/mem/ruby/network/MessageBuffer.hh 73d4798871a5 > src/mem/ruby/network/MessageBuffer.cc 73d4798871a5 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 73d4798871a5 > src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc 73d4798871a5 > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.cc 73d4798871a5 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 73d4798871a5 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc 73d4798871a5 > src/mem/ruby/network/garnet/flexible-pipeline/flit.cc 73d4798871a5 > src/mem/ruby/network/simple/PerfectSwitch.cc 73d4798871a5 > src/mem/ruby/network/simple/Throttle.cc 73d4798871a5 > > Diff: http://reviews.gem5.org/r/2928/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
