----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2940/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10919:eef3b986946a --------------------------- base: Rewrite the CircleBuf to fix bugs and add serialization The CircleBuf class has at least one bug causing it to overwrite the wrong elements when wrapping. The current code has a lot of unused functionality and duplicated code. This changeset replaces the old implementation with a new version that supports serialization and arbitrary types in the buffer (not just char). Diffs ----- src/base/SConscript 5c76426fd9ee src/base/circlebuf.hh 5c76426fd9ee src/base/circlebuf.cc 5c76426fd9ee src/dev/terminal.hh 5c76426fd9ee src/dev/terminal.cc 5c76426fd9ee src/unittest/SConscript 5c76426fd9ee src/unittest/circlebuf.cc PRE-CREATION src/unittest/circletest.cc 5c76426fd9ee Diff: http://reviews.gem5.org/r/2940/diff/ Testing ------- Tested with unit test that exercises all corner cases (different buffer wrap arounds etc.). Used extensively as a FIFO for the DMA engine in RB2942. All regressions pass, but some terminal outputs change since buffer wraparounds now work correctly. Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
