----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2945/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10923:ac0c11d8dfd6 --------------------------- mem: Cleanup packet accessor methods The Packet::get() and Packet::set() methods both have very strange semantics. Currently, they automatically convert between the guest system's endianness and the host system's endianness. This behavior is usually undesired and unexpected. This patch introduces three new method pairs to access data: * getLE() / setLE() - Get data stored as little endian. * getBE() / setBE() - Get data stored as big endian. * get(ByteOrder) / set(v, ByteOrder) - Configurable endianness For example, a little endian device that is receiving a write request will use teh getLE() method to get the data from the packet. The old interface will be deprecated once all existing devices have been ported to the new interface. Diffs ----- src/mem/packet.hh 5c76426fd9ee src/mem/packet_access.hh 5c76426fd9ee Diff: http://reviews.gem5.org/r/2945/diff/ Testing ------- Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
