----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2951/#review6752 -----------------------------------------------------------
Ship it! The patch seems fine to me. I suggest that you merge the changes to ruby/system/System.cc to your original patch on checkpointing. The change to eventq.hh should go in separately. - Nilay Vaish On July 8, 2015, 8:32 p.m., Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2951/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 8:32 p.m.) > > > Review request for Default and Ruby Reviewers. > > > Repository: gem5 > > > Description > ------- > > ruby: Fix memWriteback() not to record auto-delete events > > Currently ruby memWriteback() hijacks the event queue to perform its flushing > events by descheduling everything, flushing, then restoring everything again. > However, events with the AutoDelete flag set will delete themselves when they > are descheduled, causing an error when attempting to schedule them again. > This is fixed by simply not recording them when taking them off the queue. A > new warning lets the user know that ruby memWriteback() may cause problems if > simulation continues. > > > Diffs > ----- > > src/mem/ruby/system/System.cc 73d4798871a5 > src/sim/eventq.hh 73d4798871a5 > > Diff: http://reviews.gem5.org/r/2951/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Jones > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
