----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2989/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10952:57fd09945e80 --------------------------- ruby: switch to explicit allocation and deletion of messages Currently messages in ruby are reference counted objects. This is a performance issue since c++ reference counting uses atomic instructions for maintaining the counts. This patch explicitly allocates and deletes messages. We see a performance improvement of about 3-5% on the only ruby fs regression test. Diffs ----- src/mem/ruby/slicc_interface/Message.cc PRE-CREATION src/mem/ruby/slicc_interface/RubyRequest.hh 9689ead7b479 src/mem/ruby/slicc_interface/SConscript 9689ead7b479 src/mem/ruby/structures/WireBuffer.hh 9689ead7b479 src/mem/ruby/structures/WireBuffer.cc 9689ead7b479 src/mem/ruby/system/DMASequencer.cc 9689ead7b479 src/mem/ruby/system/Sequencer.cc 9689ead7b479 src/mem/slicc/symbols/Type.py 9689ead7b479 src/mem/protocol/MESI_Two_Level-L1cache.sm 9689ead7b479 src/mem/protocol/MESI_Two_Level-L2cache.sm 9689ead7b479 src/mem/protocol/MESI_Two_Level-dir.sm 9689ead7b479 src/mem/protocol/MESI_Two_Level-dma.sm 9689ead7b479 src/mem/ruby/network/MessageBuffer.hh 9689ead7b479 src/mem/ruby/network/MessageBuffer.cc 9689ead7b479 src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.hh 9689ead7b479 src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc 9689ead7b479 src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc 9689ead7b479 src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh 9689ead7b479 src/mem/ruby/network/garnet/fixed-pipeline/flit_d.cc 9689ead7b479 src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.hh 9689ead7b479 src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc 9689ead7b479 src/mem/ruby/network/garnet/flexible-pipeline/Router.cc 9689ead7b479 src/mem/ruby/network/garnet/flexible-pipeline/flit.hh 9689ead7b479 src/mem/ruby/network/garnet/flexible-pipeline/flit.cc 9689ead7b479 src/mem/ruby/network/simple/PerfectSwitch.cc 9689ead7b479 src/mem/ruby/network/simple/Throttle.cc 9689ead7b479 src/mem/ruby/slicc_interface/AbstractController.cc 9689ead7b479 src/mem/ruby/slicc_interface/Message.hh 9689ead7b479 Diff: http://reviews.gem5.org/r/2989/diff/ Testing ------- Thanks, Nilay Vaish _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
