> On June 26, 2015, 11:45 a.m., Andreas Hansson wrote: > > Thanks for the patch. > > > > I am wondering if this is really the way to go. I would argue that one > > enormous crossbar is not realistic for 32+ cores, and if you would create > > this as a number of clusters the problem should go away. Have you > > considered that? > > > > Thus, you place 4-8 cores in a cluster, with their own ClusterXBar. This > > crossbar is then connected to the SystemXBar. By doing this the ClusterXBar > > should only see 16 ports and the total system could still accommodate 16 * > > 16 cores or more.
Any comments? I am about to post some patches for the snoop filter, and as a follow up we could easily make the snoop mask "dense" in that it would only track snooping ports. That would allow you the 32+ cores for a single-hop crossbar, as mentioned above. Would that be enough? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2916/#review6606 ----------------------------------------------------------- On June 25, 2015, 3:05 a.m., Chang Hyun Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2916/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 3:05 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > #Changing SnoopMask type from `uint64_t` to `std::bitset` > This allows the size of the system (core count) to be larger than the current > system. > The # of slave ports was 2xcore + 1 for a basic `example/se.py` simulation > with `--caches` option. > Thus the maximum core size when using SnoopFilter was 31 due to the 64 bit > type. > Bitset allows this to be expanded, allowing the use of SnoopFilter to be used > in larger core count systems. > > TODO: Dynamically allow the build system to specify the `MAX_CORES` macro > value. > > > Diffs > ----- > > src/mem/snoop_filter.hh e4f63f1d502d > src/mem/snoop_filter.cc e4f63f1d502d > > Diff: http://reviews.gem5.org/r/2916/diff/ > > > Testing > ------- > > Testing done on config file `example/se.py` with `--caches option`. > (Modified code to add the `SnoopFilter()` into the `SystemXBar`) > > > Thanks, > > Chang Hyun Park > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
