----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3044/#review7028 -----------------------------------------------------------
Hi Andreas. I'm wondering why this patch was checked in (http://repo.gem5.org/gem5/rev/842f56345a42). It doesn't have a 'Ship It', and the review request is only 4 days old. This change also breaks some packet use cases we have in gem5-gpu. Specifically, this change now requires that Requests be translated or otherwise find a valid physical address before a packet can be constructed. I'm not convinced that this is a reasonable requirement, especially since packets can be used between components that operate completely on virtual addresses. Can you please revert this change? - Joel Hestness On Aug. 19, 2015, 9:06 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3044/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 9:06 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11055:dc0a15e6e113 > --------------------------- > mem: Reflect that packet address and size are always valid > > This patch simplifies the packet, and removes the possibility of > creating a packet without a valid address and/or size. Under no > circumstances are these fields set at a later point, and thus they > really have to be provided at construction time. > > The patch also fixes a case there the MinorCPU creates a packet > without a valid address and size, only to later delete it. > > > Diffs > ----- > > src/cpu/minor/lsq.cc 110cce93d398 > src/mem/packet.hh 110cce93d398 > > Diff: http://reviews.gem5.org/r/3044/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
