----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3061/#review7252 -----------------------------------------------------------
Ship it! So you are assuming that most ports do not need snooping. src/mem/coherent_xbar.cc (lines 133 - 137) <http://reviews.gem5.org/r/3061/#comment6175> Does the placement of these lines matter? - Nilay Vaish On Aug. 21, 2015, 3:50 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3061/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 3:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11064:900d7faf3522 > --------------------------- > mem: Only track snooping ports in the snoop filter > > This patch changes the tracking of ports in the snoop filter to use > local dense port IDs so that we can have 64 snooping ports (rather > than crossbar slave ports). This is achieved by adding a simple > remapping vector that translates the actal port IDs into the local > slave IDs used in the SnoopMask. > > Ultimately this patch allows us to scale to much larger systems > without introducing a hierarchy of crossbars. > > > Diffs > ----- > > src/mem/coherent_xbar.cc 842f56345a42 > src/mem/snoop_filter.hh 842f56345a42 > > Diff: http://reviews.gem5.org/r/3061/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
